diff options
| author | Ben Chan <benchan@chromium.org> | 2017-08-11 14:16:47 -0700 |
|---|---|---|
| committer | Dan Williams <dcbw@redhat.com> | 2017-08-11 17:09:13 -0500 |
| commit | c02dcd397ab6ccbc3c021bf6d96d76de7bce8b91 (patch) | |
| tree | bed4b4c886d9eadc0febdebc243a8f59af2a3c04 | |
| parent | dec53d6ef65d1e0ebd10e278fe11762edd14e5bf (diff) | |
libmm-glib,sms-properties: fix potential NULL dereference
This patch fixes a potential NULL referenece issue in
mm_sms_properties_get_data() where it accesses `self->priv->data->data'
when `self->priv->data' could be potentially NULL.
| -rw-r--r-- | libmm-glib/mm-sms-properties.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/libmm-glib/mm-sms-properties.c b/libmm-glib/mm-sms-properties.c index da4aa804..b0ff5a3b 100644 --- a/libmm-glib/mm-sms-properties.c +++ b/libmm-glib/mm-sms-properties.c @@ -157,10 +157,10 @@ mm_sms_properties_get_data (MMSmsProperties *self, { g_return_val_if_fail (MM_IS_SMS_PROPERTIES (self), NULL); - if (self->priv->data && data_len) - *data_len = self->priv->data->len; + if (data_len) + *data_len = (self->priv->data ? self->priv->data->len : 0); - return self->priv->data->data; + return (self->priv->data ? self->priv->data->data : NULL); } /** |