aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNathan Williams <njw@chromium.org>2011-06-23 18:01:46 -0400
committerDan Williams <dcbw@redhat.com>2011-06-30 12:23:10 -0500
commitb7820cf6e15eb245d4726f8cfbe20ce24466188b (patch)
tree36f9a17e2cdbf692c20d15da19b4773e70f14b40
parent895f0f2ea3868091baefa897d88a6fbc3a0ca897 (diff)
gsm: handle case of entirely empty SPN correctly
BUG=none TEST=Insert a SIM with a present but empty (all 0xFF) SPN and check the system log for a (lack of) assertion errors from mm_charset_gsm_unpacked_to_utf8(). Change-Id: I1250494b9757c9bfdce56402a4471c598f41223f Reviewed-on: http://gerrit.chromium.org/gerrit/3139 Reviewed-by: Eric Shienbrood <ers@chromium.org> Tested-by: Nathan J. Williams <njw@chromium.org>
-rw-r--r--src/mm-generic-gsm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mm-generic-gsm.c b/src/mm-generic-gsm.c
index d814c57c..c3c3d472 100644
--- a/src/mm-generic-gsm.c
+++ b/src/mm-generic-gsm.c
@@ -2002,7 +2002,7 @@ get_spn_done (MMAtSerialPort *port,
}
/* Remove the FF filler at the end */
- while (bin[buflen - 1] == (char)0xff)
+ while (buflen > 1 && bin[buflen - 1] == (char)0xff)
buflen--;
/* First byte is metadata; remainder is GSM-7 unpacked into octets; convert to UTF8 */