diff options
| author | Yunlian Jiang <yunlian@google.com> | 2015-03-27 20:30:18 +0100 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2015-03-27 20:31:24 +0100 |
| commit | 977cf658a6bf92a764632f69e99fe39a39e0ee4d (patch) | |
| tree | 52e9a40160d874ba96a1e25ccbe6708485ff66a6 | |
| parent | 948be2343a592d35403a8e7319fbe21952e56256 (diff) | |
tests: fix memory leaks
| -rw-r--r-- | plugins/huawei/tests/test-modem-helpers-huawei.c | 14 | ||||
| -rw-r--r-- | plugins/icera/tests/test-modem-helpers-icera.c | 2 | ||||
| -rw-r--r-- | plugins/mbm/tests/test-modem-helpers-mbm.c | 2 |
3 files changed, 13 insertions, 5 deletions
diff --git a/plugins/huawei/tests/test-modem-helpers-huawei.c b/plugins/huawei/tests/test-modem-helpers-huawei.c index 9e92eee2..ffc0854e 100644 --- a/plugins/huawei/tests/test-modem-helpers-huawei.c +++ b/plugins/huawei/tests/test-modem-helpers-huawei.c @@ -420,6 +420,7 @@ test_prefmode_response (void) found = mm_huawei_parse_prefmode_response (prefmode_response_tests[i].str, combinations, &error); + g_assert_no_error (error); g_assert (found != NULL); g_assert_cmpuint (found->allowed, ==, prefmode_response_tests[i].allowed); g_assert_cmpuint (found->preferred, ==, prefmode_response_tests[i].preferred); @@ -672,6 +673,7 @@ test_syscfg_response (void) combinations, &error); + g_assert_no_error (error); g_assert (found != NULL); g_assert_cmpuint (found->allowed, ==, syscfg_response_tests[i].allowed); g_assert_cmpuint (found->preferred, ==, syscfg_response_tests[i].preferred); @@ -993,6 +995,7 @@ test_syscfgex_response (void) combinations, &error); + g_assert_no_error (error); g_assert (found != NULL); g_assert_cmpuint (found->allowed, ==, syscfgex_response_tests[i].allowed); g_assert_cmpuint (found->preferred, ==, syscfgex_response_tests[i].preferred); @@ -1085,8 +1088,10 @@ test_nwtime (void) g_assert (nwtime_tests[i].leap_seconds == mm_network_timezone_get_leap_seconds (tz)); } - if (iso8601) - g_free (iso8601); + g_free (iso8601); + + if (tz) + g_object_unref (tz); } } @@ -1125,11 +1130,10 @@ test_time (void) g_assert (ret == time_tests[i].ret); g_assert (ret == (error ? FALSE : TRUE)); + g_clear_error (&error); g_assert_cmpstr (time_tests[i].iso8601, ==, iso8601); - - if (iso8601) - g_free (iso8601); + g_free (iso8601); } } diff --git a/plugins/icera/tests/test-modem-helpers-icera.c b/plugins/icera/tests/test-modem-helpers-icera.c index e7d16454..2e7b26fc 100644 --- a/plugins/icera/tests/test-modem-helpers-icera.c +++ b/plugins/icera/tests/test-modem-helpers-icera.c @@ -141,6 +141,7 @@ test_ipdpaddr (void) g_assert_cmpint (dnslen, ==, 1); g_assert_cmpstr (dns[0], ==, ipdpaddr_tests[i].ipv4_dns1); g_assert_cmpstr (dns[1], ==, ipdpaddr_tests[i].ipv4_dns2); + g_object_unref (ipv4); } else g_assert (ipv4 == NULL); @@ -166,6 +167,7 @@ test_ipdpaddr (void) dnslen = g_strv_length ((gchar **) dns); g_assert_cmpint (dnslen, ==, 1); g_assert_cmpstr (dns[0], ==, ipdpaddr_tests[i].ipv6_dns1); + g_object_unref (ipv6); } else g_assert (ipv6 == NULL); } diff --git a/plugins/mbm/tests/test-modem-helpers-mbm.c b/plugins/mbm/tests/test-modem-helpers-mbm.c index 2e6dd1a3..0c48894b 100644 --- a/plugins/mbm/tests/test-modem-helpers-mbm.c +++ b/plugins/mbm/tests/test-modem-helpers-mbm.c @@ -96,6 +96,7 @@ test_e2ipcfg (void) g_assert_cmpint (dnslen, ==, 1); g_assert_cmpstr (dns[0], ==, tests[i].ipv4_dns1); g_assert_cmpstr (dns[1], ==, tests[i].ipv4_dns2); + g_object_unref (ipv4); } else g_assert (ipv4 == NULL); @@ -122,6 +123,7 @@ test_e2ipcfg (void) g_assert_cmpint (dnslen, ==, 1); g_assert_cmpstr (dns[0], ==, tests[i].ipv6_dns1); g_assert_cmpstr (dns[1], ==, tests[i].ipv6_dns2); + g_object_unref (ipv6); } else g_assert (ipv6 == NULL); } |