mbm: use unsolicited access technology updates

1 files changed, 50 insertions, 60 deletions

diff --git a/plugins/mm-modem-mbm.c b/plugins/mm-modem-mbm.c
index ed39cec4..afb7d121 100644
--- a/plugins/mm-modem-mbm.c
+++ b/plugins/mm-modem-mbm.c
@@ -52,11 +52,6 @@ G_DEFINE_TYPE_EXTENDED (MMModemMbm, mm_modem_mbm, MM_TYPE_GENERIC_GSM, 0,
 #define MBM_NETWORK_MODE_2G   5
 #define MBM_NETWORK_MODE_3G   6
 
-#define MBM_ERINFO_2G_GPRS  1
-#define MBM_ERINFO_2G_EGPRS 2
-#define MBM_ERINFO_3G_UMTS  1
-#define MBM_ERINFO_3G_HSDPA 2
-
 typedef struct {
     guint reg_id;
     gboolean have_emrdy;
@@ -129,9 +124,6 @@ register_done (gpointer user_data)
     primary = mm_generic_gsm_get_port (MM_GENERIC_GSM (self), MM_PORT_TYPE_PRIMARY);
     g_assert (primary);
 
-    mm_serial_port_queue_command (primary, "+CREG=1", 3, NULL, NULL);
-    mm_serial_port_queue_command (primary, "+CMER=3,0,0,1", 3, NULL, NULL);
-
     parent_modem_iface = g_type_interface_peek_parent (MM_MODEM_GSM_NETWORK_GET_INTERFACE (self));
     parent_modem_iface->do_register (MM_MODEM_GSM_NETWORK (self),
                                      reg_data->network_id,
@@ -214,57 +206,47 @@ set_allowed_mode (MMGenericGsm *gsm,
     g_free (command);
 }
 
-#if 0
 static void
-get_network_mode_done (MMSerialPort *port,
-                       GString *response,
-                       GError *error,
-                       gpointer user_data)
+mbm_erinfo_received (MMSerialPort *port,
+                     GMatchInfo *info,
+                     gpointer user_data)
 {
-    MMCallbackInfo *info = (MMCallbackInfo *) user_data;
-    char *erinfo;
-    int mode = 0, gsm = 0, umts = 0;
-    gboolean parsed = FALSE;
-
-    if (error) {
-        info->error = g_error_copy (error);
-        goto done;
-    }
-
-    erinfo = strstr (response->str, "*ERINFO:");
-    if (!erinfo)
-        goto done;
-
-    if (sscanf (erinfo + 8, "%d,%d,%d", &mode, &gsm, &umts) != 3)
-        goto done;
-
-    if (gsm || umts) {
-        MMModemGsmMode mm_mode = MM_MODEM_GSM_MODE_ANY;
-
-        if (gsm == MBM_ERINFO_2G_GPRS)
-            mm_mode = MM_MODEM_GSM_MODE_GPRS;
-        else if (gsm == MBM_ERINFO_2G_EGPRS)
-            mm_mode = MM_MODEM_GSM_MODE_EDGE;
-        else if (umts == MBM_ERINFO_3G_UMTS)
-            mm_mode = MM_MODEM_GSM_MODE_UMTS;
-        else if (umts == MBM_ERINFO_3G_HSDPA)
-            mm_mode = MM_MODEM_GSM_MODE_HSDPA;
-        else
-            g_debug ("%s unknown network mode %d,%d", __FUNCTION__, gsm, umts);
-
-        mm_callback_info_set_result (info, GUINT_TO_POINTER (mm_mode), NULL);
-        parsed = TRUE;
+    MMModemGsmAccessTech act = MM_MODEM_GSM_ACCESS_TECH_UNKNOWN;
+    char *str;
+
+    str = g_match_info_fetch (info, 2);
+    if (str) {
+        switch (atoi (str)) {
+        case 1:
+            act = MM_MODEM_GSM_ACCESS_TECH_GPRS;
+            break;
+        case 2:
+            act = MM_MODEM_GSM_ACCESS_TECH_EDGE;
+            break;
+        default:
+            break;
+        }
     }
-
-done:
-    if (!error && !parsed) {
-        info->error = g_error_new_literal (MM_MODEM_ERROR, MM_MODEM_ERROR_GENERAL,
-                                           "Could not parse network mode results");
+    g_free (str);
+
+    /* 3G modes take precedence */
+    str = g_match_info_fetch (info, 3);
+    if (str) {
+        switch (atoi (str)) {
+        case 1:
+            act = MM_MODEM_GSM_ACCESS_TECH_UMTS;
+            break;
+        case 2:
+            act = MM_MODEM_GSM_ACCESS_TECH_HSDPA;
+            break;
+        default:
+            break;
+        }
     }
+    g_free (str);
 
-    mm_callback_info_schedule (info);
+    mm_generic_gsm_update_access_technology (MM_GENERIC_GSM (user_data), act);
 }
-#endif
 
 static void
 get_allowed_mode_done (MMSerialPort *port,
@@ -364,6 +346,10 @@ mbm_enable_done (MMSerialPort *port,
 {
     MMCallbackInfo *info = (MMCallbackInfo *) user_data;
 
+    /* Start unsolicited signal strength and access technology responses */
+    mm_serial_port_queue_command (port, "+CMER=3,0,0,1", 3, NULL, NULL);
+    mm_serial_port_queue_command (port, "*ERINFO=1", 3, NULL, NULL);
+
     mm_generic_gsm_enable_complete (MM_GENERIC_GSM (info->modem), error, info);
 }
 
@@ -456,10 +442,10 @@ typedef struct {
 } DisableInfo;
 
 static void
-disable_creg_cmer_done (MMSerialPort *port,
-                        GString *response,
-                        GError *error,
-                        gpointer user_data)
+disable_unsolicited_done (MMSerialPort *port,
+                          GString *response,
+                          GError *error,
+                          gpointer user_data)
 
 {
     MMModem *parent_modem_iface;
@@ -486,8 +472,8 @@ disable (MMModem *modem,
     primary = mm_generic_gsm_get_port (MM_GENERIC_GSM (modem), MM_PORT_TYPE_PRIMARY);
     g_assert (primary);
 
-    /* Turn off unsolicited +CIEV signal strength indicator */
-    mm_serial_port_queue_command (primary, "+CREG=0;+CMER=0", 5, disable_creg_cmer_done, info);
+    /* Turn off unsolicited responses */
+    mm_serial_port_queue_command (primary, "+CMER=0;*ERINFO=0", 5, disable_unsolicited_done, info);
 }
 
 static void
@@ -813,12 +799,16 @@ grab_port (MMModem *modem,
 
         /* also consume unsolicited mbm messages we are not interested in them - see LP: #416418 */
         regex = g_regex_new ("\\R\\*ESTKSMENU:.*\\R", G_REGEX_RAW | G_REGEX_OPTIMIZE | G_REGEX_MULTILINE | G_REGEX_NEWLINE_CRLF, G_REGEX_MATCH_NEWLINE_CRLF, NULL);

-        mm_serial_port_add_unsolicited_msg_handler (MM_SERIAL_PORT (port), regex, NULL, modem, NULL);
+        mm_serial_port_add_unsolicited_msg_handler (MM_SERIAL_PORT (port), regex, NULL, NULL, NULL);
         g_regex_unref (regex);
 
         regex = g_regex_new ("\\r\\n\\*EMWI: (\\d),(\\d).*\\r\\n", G_REGEX_RAW | G_REGEX_OPTIMIZE, 0, NULL);
         mm_serial_port_add_unsolicited_msg_handler (MM_SERIAL_PORT (port), regex, NULL, NULL, NULL);
         g_regex_unref (regex);
+
+        regex = g_regex_new ("\\r\\n\\*ERINFO:\\s*(\\d),(\\d),(\\d).*\\r\\n", G_REGEX_RAW | G_REGEX_OPTIMIZE, 0, NULL);
+        mm_serial_port_add_unsolicited_msg_handler (MM_SERIAL_PORT (port), regex, mbm_erinfo_received, modem, NULL);
+        g_regex_unref (regex);
     }
 
     return TRUE;