diff options
| author | Ivan Mikhanchuk <ivanmikh@pm.me> | 2021-04-27 21:33:12 -0700 |
|---|---|---|
| committer | Ivan Mikhanchuk <ivan.mikhanchuk@quectel.com> | 2021-06-11 17:22:04 -0700 |
| commit | 4b4ce6c44573ed72841d5f9c1c154e941bd900b6 (patch) | |
| tree | 59013a8675d6b916053dd5f027f8249c27a5e914 | |
| parent | 611d59883606e30a226dd9066b503c3b857edd39 (diff) | |
port-serial: do not call config_fd on wwan qcdm port
wwan qcdm port is not a serial port, calling config_fd on it
will always fail, i.e.:
ModemManager[124587]: <debug> [1619584182.125262] [wwan0p1QCDM/probe] probing QCDM...
ModemManager[124587]: <debug> [1619584182.125398] [wwan0p1QCDM/qcdm] opening serial port...
ModemManager[124587]: <debug> [1619584182.151759] [wwan0p1QCDM/qcdm] failed to configure serial device
ModemManager[124587]: <warn> [1619584182.151836] [wwan0p1QCDM/qcdm] failed to open serial device
ModemManager[124587]: <warn> [1619584182.170152] [plugin-manager] task 1,wwan0p1QCDM: error when checking support with plugin 'generic': (wwan/wwan0p1QCDM) Failed to open QCDM port: Failed to open QCDM port: -2
| -rw-r--r-- | src/mm-port-serial.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mm-port-serial.c b/src/mm-port-serial.c index e86f3702..8b6e34ec 100644 --- a/src/mm-port-serial.c +++ b/src/mm-port-serial.c @@ -1231,7 +1231,8 @@ mm_port_serial_open (MMPortSerial *self, GError **error) } g_warn_if_fail (MM_PORT_SERIAL_GET_CLASS (self)->config_fd); - if (self->priv->fd >= 0 && !MM_PORT_SERIAL_GET_CLASS (self)->config_fd (self, self->priv->fd, error)) { + if (self->priv->fd >= 0 && mm_port_get_subsys (MM_PORT (self)) != MM_PORT_SUBSYS_WWAN && + !MM_PORT_SERIAL_GET_CLASS (self)->config_fd (self, self->priv->fd, error)) { mm_obj_dbg (self, "failed to configure serial device"); goto error; } |