diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2020-01-31 07:42:56 +0100 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2020-01-31 15:18:35 +0100 |
| commit | 497398158f34e84a746e3208fa289c0912303966 (patch) | |
| tree | 4ebb36a6041501a6029b2bac72df1d718783672f | |
| parent | eff4ca989ddadd2fd27a66bdfe54792cd53015bd (diff) | |
cinterion: fix warnings with -Wimplicit-fallthrough
cinterion/mm-broadband-bearer-cinterion.c: In function ‘dial_3gpp_context_step’:
cinterion/mm-broadband-bearer-cinterion.c:393:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
393 | ctx->step++;
| ~~~~~~~~~^~
cinterion/mm-broadband-bearer-cinterion.c:396:5: note: here
396 | case DIAL_3GPP_CONTEXT_STEP_AUTH: {
| ^~~~
cinterion/mm-broadband-bearer-cinterion.c:419:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
419 | ctx->step++;
| ~~~~~~~~~^~
cinterion/mm-broadband-bearer-cinterion.c:422:5: note: here
422 | case DIAL_3GPP_CONTEXT_STEP_START_SWWAN: {
| ^~~~
cinterion/mm-broadband-bearer-cinterion.c: In function ‘disconnect_3gpp_context_step’:
cinterion/mm-broadband-bearer-cinterion.c:613:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
613 | ctx->step++;
| ~~~~~~~~~^~
cinterion/mm-broadband-bearer-cinterion.c:615:5: note: here
615 | case DISCONNECT_3GPP_CONTEXT_STEP_STOP_SWWAN: {
| ^~~~
| -rw-r--r-- | plugins/cinterion/mm-broadband-bearer-cinterion.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/plugins/cinterion/mm-broadband-bearer-cinterion.c b/plugins/cinterion/mm-broadband-bearer-cinterion.c index 939bdd65..5c893b69 100644 --- a/plugins/cinterion/mm-broadband-bearer-cinterion.c +++ b/plugins/cinterion/mm-broadband-bearer-cinterion.c @@ -389,9 +389,8 @@ dial_3gpp_context_step (GTask *task) return; } - /* Fall down to next step */ ctx->step++; - } + } /* fall through */ case DIAL_3GPP_CONTEXT_STEP_AUTH: { gchar *command; @@ -414,10 +413,9 @@ dial_3gpp_context_step (GTask *task) return; } - /* Fall down to next step */ mm_dbg ("cinterion dial step %u/%u: authentication not required", ctx->step, DIAL_3GPP_CONTEXT_STEP_LAST); ctx->step++; - } + } /* fall through */ case DIAL_3GPP_CONTEXT_STEP_START_SWWAN: { gchar *command; @@ -612,8 +610,8 @@ disconnect_3gpp_context_step (GTask *task) switch (ctx->step) { case DISCONNECT_3GPP_CONTEXT_STEP_FIRST: - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISCONNECT_3GPP_CONTEXT_STEP_STOP_SWWAN: { gchar *command; |