aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksander Morgado <aleksander@aleksander.es>2021-05-18 12:24:39 +0200
committerAleksander Morgado <aleksander@aleksander.es>2021-05-18 14:51:05 +0200
commit21ff48ed7d56837567aff3e396acf3bfd24cbc02 (patch)
treeb2d9830c03b37ca85514fab85697a1f471e78fdd
parenta325acd6b1ae3376bb0f9f3eb83ce44617115a55 (diff)
libmm-glib: drop default timeout checks in Command()
The g_dbus_proxy_get_default_timeout() is by default -1 unless explicitly updated, so the check doesn't make any sense really. We didn't see any warning produced because mmcli provides an explicit timeout of 30s, so it was never the default -1.
-rw-r--r--libmm-glib/mm-modem.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/libmm-glib/mm-modem.c b/libmm-glib/mm-modem.c
index 02e322dd..40629051 100644
--- a/libmm-glib/mm-modem.c
+++ b/libmm-glib/mm-modem.c
@@ -2900,8 +2900,6 @@ mm_modem_command (MMModem *self,
g_return_if_fail (MM_IS_MODEM (self));
- if (g_dbus_proxy_get_default_timeout (G_DBUS_PROXY (self)) < timeout)
- g_warning ("Requested command timeout is shorter than the default DBus timeout");
mm_gdbus_modem_call_command (MM_GDBUS_MODEM (self), cmd, timeout, cancellable, callback, user_data);
}
@@ -2935,9 +2933,6 @@ mm_modem_command_sync (MMModem *self,
g_return_val_if_fail (MM_IS_MODEM (self), NULL);
- if (g_dbus_proxy_get_default_timeout (G_DBUS_PROXY (self)) < timeout)
- g_warning ("Requested command timeout is shorter than the default DBus timeout");
-
if (!mm_gdbus_modem_call_command_sync (MM_GDBUS_MODEM (self), cmd, timeout, &result, cancellable, error))
return NULL;